-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some examples for documentation #94
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-documenter #94 +/- ##
===============================================
Coverage 97.74% 97.74%
===============================================
Files 6 6
Lines 133 133
===============================================
Hits 130 130
Misses 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks very nice. One request for clarification and also are you manually creating the examples.jl?
I assume we actually want those to be generated in the github action vs committed or in make.jl?
b551042
to
72a2a3d
Compare
Give me a ping when this is ready for review |
Do you want some support to unstick this @SamuelBrand1? Note the discussion in #99 that we likely want to deal with that here. |
This PR builds on #93 with the goal of adding some example usage/or underlying maths of
EpiAware
.Main addition
Three
.jl
scripts which were in a subdirectory of/test
are now in thedoc/example
subdir. These were rendered to Documenter flavour markdown byLiterate.markdown
(not a dep of this package) in thedoc/src/man
folder. This means that the blocks tagged@example
are run when documenter rendersmd
to HTML whilst creating the documentation.These have been added as links in the sidebar of the main doc page.
Minor changes/sharp bits
EpiAware/doc
environment in the build process. The main usage expects a package available from the Julia registry; the alternative as suggested by Documenter guide was to includesrc
in theLOAD_PATH
environmental variable. This meant adding all the deps ofEpiAware
to theEpiAware/doc
Project.toml
which "felt" clunky but works.linkcheck
. This caused an error, which debugging should be an issue. I think this is because we have placeholder links in the documentation.makedocs
to:This means that local rendering still has active links when view from your browser.