-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding post-artifact action and updating README #1
Conversation
I changed how to id the messages, that's why we now have two sets of them, @dylanhmorris and @swo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @gvegayon. A few questions and comments.
@gvegayon lmk when this is ready for re-review |
Ready for re-review, @dylanhmorris! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good; thanks @gvegayon! One question: perhaps I am missing something, but it appears that there there is no explicit error raised if the user attempts to trigger the action with an event other than a PR. I am not sure the actual errors that will occur in those cases be will be informative, so I think we should add an explicit informative error, but I am happy to be persuaded otherwise.
If we add an error, then we would be forcing the user to use the |
Added an error msg as discussed, @dylanhmorris! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gvegayon!
Note that the artifact is working as we got four different comments from
github-actions[bot]
!