Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding post-artifact action and updating README #1

Merged
merged 19 commits into from
Oct 23, 2024
Merged

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented Oct 3, 2024

Note that the artifact is working as we got four different comments from github-actions[bot]!

@gvegayon gvegayon requested review from swo and dylanhmorris October 3, 2024 20:17
Copy link

github-actions bot commented Oct 3, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-ubuntu-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-01-02T16:20:25Z. You can re-generate it by re-running the workflow here)

Copy link

github-actions bot commented Oct 3, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-macos-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-01-02T16:20:25Z. You can re-generate it by re-running the workflow here)

Copy link

github-actions bot commented Oct 3, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-windows-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-01-02T16:20:25Z. You can re-generate it by re-running the workflow here)

Copy link

github-actions bot commented Oct 3, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-rocker is ready for download 👉 here 👈!
(The artifact expires on 2025-01-02T16:20:25Z. You can re-generate it by re-running the workflow here)

Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-macos-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-01-20T23:17:59Z. You can re-generate it by re-running the workflow here.)

Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-ubuntu-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-01-20T23:17:59Z. You can re-generate it by re-running the workflow here.)

Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-windows-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-01-20T23:17:59Z. You can re-generate it by re-running the workflow here.)

Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution @gvegayon 🚀! Your readme-rocker is ready for download 👉 here 👈!
(The artifact expires on 2025-01-20T23:17:59Z. You can re-generate it by re-running the workflow here.)

@gvegayon
Copy link
Member Author

gvegayon commented Oct 4, 2024

I changed how to id the messages, that's why we now have two sets of them, @dylanhmorris and @swo.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @gvegayon. A few questions and comments.

README.md Show resolved Hide resolved
post-artifact/README.md Outdated Show resolved Hide resolved
post-artifact/action.yml Outdated Show resolved Hide resolved
post-artifact/action.yml Outdated Show resolved Hide resolved
post-artifact/action.yml Outdated Show resolved Hide resolved
post-artifact/action.yml Outdated Show resolved Hide resolved
post-artifact/action.yml Show resolved Hide resolved
post-artifact/README.md Show resolved Hide resolved
post-artifact/action.yml Show resolved Hide resolved
post-artifact/scripts/compose-msg.py Outdated Show resolved Hide resolved
@gvegayon gvegayon requested a review from dylanhmorris October 9, 2024 17:50
@swo swo removed their request for review October 9, 2024 18:00
@dylanhmorris
Copy link
Collaborator

@gvegayon lmk when this is ready for re-review

@gvegayon
Copy link
Member Author

Ready for re-review, @dylanhmorris!

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good; thanks @gvegayon! One question: perhaps I am missing something, but it appears that there there is no explicit error raised if the user attempts to trigger the action with an event other than a PR. I am not sure the actual errors that will occur in those cases be will be informative, so I think we should add an explicit informative error, but I am happy to be persuaded otherwise.

@gvegayon
Copy link
Member Author

This looks very good; thanks @gvegayon! One question: perhaps I am missing something, but it appears that there there is no explicit error raised if the user attempts to trigger the action with an event other than a PR. I am not sure the actual errors that will occur in those cases be will be informative, so I think we should add an explicit informative error, but I am happy to be persuaded otherwise.

If we add an error, then we would be forcing the user to use the if: {{ on PR only }} condition, which takes it back to the original design in which we were making the action run only on PRs. In other words, if we are going into the trouble of erroring when the user is not calling this on a PR, why don't we make it run on PRs only by construction?

@gvegayon
Copy link
Member Author

Added an error msg as discussed, @dylanhmorris!

@gvegayon gvegayon requested a review from dylanhmorris October 22, 2024 23:21
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gvegayon!

@dylanhmorris dylanhmorris merged commit 99477c1 into main Oct 23, 2024
4 checks passed
@dylanhmorris dylanhmorris deleted the first-commit branch October 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants