-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition Dev environment Infrastructure to ECS #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, just a few comments:
This reverts commit e58c03f.
…, removed -out to plan to fix stale error,added -replace to last terraform apply
…oc terraform plan
All comments addressed and review changes made, ready for last review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty ready! My comments are just about extra comments that have been left. While I'd love to see these cleaned up, I won't block it on that. Feel free to clean them up now or do a follow-up PR if that's easier. Approved!
default = "skylight" | ||
} | ||
|
||
# Manually update to set the version you want to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment could be removed.
} | ||
|
||
|
||
# If intent is to pull from the phdi GHCR, set disable_ecr to true (default is false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is used internally by the qc team and not a template used by others, the comments in this section could be removed.
PULL REQUEST
Summary
S3 bucket named
query-connector-tfstate-dev
, used to store the terraform tfstateIAM role named
qc-github-role-skylight
used by Github actions to complete actions in AWS accountDynamodb table named
query-connector-tfstate-lock-dev
used to lock the tfstate fileRelated Issue
Moved the infrastructure from EKS to ECS to expedite deployments and to match applications needs.
Fixes #
Additional Information
Anything else the review team should know?
Checklist