add query building tests #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dibbs-query-connector into bob/query-building-tests
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…dibbs-query-connector into bob/query-building-tests
fzhao99
commented
Jan 23, 2025
fzhao99
requested review from
nickclyde,
katyasoup,
robertandremitchell and
johanna-skylight
robertandremitchell
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
lgtm, a few edge tests were flaky, but I know running locally has always been a tad more fragile on my machine fwiw
2 flaky
[Microsoft Edge] › customize_query.spec.ts:115:7 › querying with the Query Connector › customize query select / deselect all filters whole DibbsConceptType, across tabs
[Microsoft Edge] › query_workflow.spec.ts:43:7 › querying with the Query Connector › successful demo user query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Adding a suite of tests (including an e2e thanks to the hard work of @katyasoup!) for the query building flow
There are some tests that I think are flaking due to improper test cleanup / parallelization, but are passing in the retries. Think I'll go ahead and merge this, but will keep an eye on this and maybe write some code to more properly reset the testing env in between tests if there are issues down the line.
If anyone wants to address this now though happy to try getting the tests fully determinate
Checklist