Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating input field length on Custom Query page #282

Merged

Conversation

robertandremitchell
Copy link
Collaborator

@robertandremitchell robertandremitchell commented Jan 14, 2025

PULL REQUEST

Summary

Making the width of the input longer.

Current:
Screenshot 2025-01-14 at 11 51 42 AM

New:
Screenshot 2025-01-14 at 11 50 26 AM

Width updated from maxw-mobile to width-card-lg with the out-the-box uswds widths. We can do a custom width, but figured it made sense to stick with the out-the-box where possible.

Related Issue

Fixes #280

Additional Information

Anything else the review team should know?

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

@robertandremitchell robertandremitchell linked an issue Jan 14, 2025 that may be closed by this pull request
@robertandremitchell robertandremitchell marked this pull request as ready for review January 14, 2025 17:04
@mikang
Copy link
Collaborator

mikang commented Jan 14, 2025

Nice! Is there a next size up?

@robertandremitchell
Copy link
Collaborator Author

Nice! Is there a next size up?

yes, next one jumps from 240 to 320. it's no trouble at all to create a custom width if we want one in that range.

Screenshot 2025-01-14 at 12 19 24 PM

@mikang
Copy link
Collaborator

mikang commented Jan 14, 2025

320px looks good! Let's go with that. Thanks for jumping on this, @robertandremitchell !

@robertandremitchell robertandremitchell merged commit f002e1a into main Jan 14, 2025
11 checks passed
@robertandremitchell robertandremitchell deleted the rob/280-elongate-the-input-field-for-the-query-name branch January 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elongate the input field for the query name
3 participants