Refactor save service response object (#3018)

* pull out saveFhirMetadata into it's own function * Use PersistenceResponse instead of Nextjs response * console log error messages * Do not close pool when done with mssql https://www.npmjs.com/package/mssql#advanced-pool-management:~:text=Also%20notice%20that,of%20the%20script. * increase sqlserver timeout to 30 s * don't return anything from save ecr data query * set pool min to 1 * Rename PersistenceResponse to SaveResponse * update the rest of the types to match save response * update comments to describe save response * Do not return error in return statement, instead just log * update tests * deconstruct Service Response object * update console error logs to log object rather than string * fix tests * Update response message to remove ecrID * Update containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts Co-authored-by: Mary McGrath <[email protected]> --------- Co-authored-by: Mary McGrath <[email protected]>
CDCgov · Dec 11, 2024 · 2c516ff · 2c516ff
1 parent 89f3e8d
commit 2c516ff
Show file tree

Hide file tree

Showing 6 changed files with 189 additions and 148 deletions.
diff --git a/containers/ecr-viewer/src/app/api/save-fhir-data/route.ts b/containers/ecr-viewer/src/app/api/save-fhir-data/route.ts
@@ -43,13 +43,19 @@ export async function POST(request: NextRequest) {
   }
 
   if (requestBody.metadata) {
-    return saveWithMetadata(
+    const { message, status } = await saveWithMetadata(
       fhirBundle,
       ecrId,
       saveSource,
       requestBody.metadata,
     );
+    return NextResponse.json({ message }, { status });
   } else {
-    return saveFhirData(fhirBundle, ecrId, saveSource);
+    const { message, status } = await saveFhirData(
+      fhirBundle,
+      ecrId,
+      saveSource,
+    );
+    return NextResponse.json({ message }, { status });
   }
 }