-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to eCR Viewer homepage #1889
Conversation
@angelathe this looks pretty close to me, only thing is the spacing between the bottom of the table and the pagination component should be 48px. it looks a little bigger than that right now |
Ahh good catch, just fixed! Kept the gap at 48px, but removed the bottom margin of the table / top margin of the pagination. |
awesome looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
I will note that when running accessibility scan it did flag the next page arrow image (>
). This was reported already.
PULL REQUEST
Summary
Related Issue
Fixes #1782
Screenshot
In order to see how the pagination functions, I temporarily set the # items per page to 10
https://github.com/CDCgov/phdi/assets/40042932/9455067a-d450-4b01-81b0-0ebdd1b90209
With items per page set to 25 (since there are < 25 items total, this is what the single page looks like)
Additional Information
USWDS Storybook: Pagination
Checklist