Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smartystreets-javascript-sdk from 2.1.2 to 3.2.0 in /frontend #6699

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 8, 2023

Bumps smartystreets-javascript-sdk from 2.1.2 to 3.2.0.

Commits
  • 04b99bb Merge pull request #68 from smarty/andrew-skon/us-reverse-geo
  • b719d65 updated source changes
  • 5ba9adb added source to the request and response and updated the tests to work with s...
  • 618ba4d Merge pull request #67 from smarty/cami/smarty-key
  • 8810c9b Merge pull request #65 from smarty/andrew/error-updates
  • 587893d fixed 400 error test and undefined payload test and indentation
  • de29643 updated expectedErrorForStatusCode and changed payloads to match error
  • ea103fb Adds smarty_key to Candidate for US Street
  • 283511b Renames to uppercase
  • b645d50 Merge pull request #66 from smarty/max/scoped-axios-instance
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [smartystreets-javascript-sdk](https://github.com/smartystreets/smartystreets-javascript-sdk) from 2.1.2 to 3.2.0.
- [Changelog](https://github.com/smarty/smartystreets-javascript-sdk/blob/master/CHANGELOG.md)
- [Commits](smarty/smartystreets-javascript-sdk@2.1.2...3.2.0)

---
updated-dependencies:
- dependency-name: smartystreets-javascript-sdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Oct 8, 2023
@dependabot dependabot bot requested review from alismx, rin-skylight, a team, fzhao99 and johanna-skylight and removed request for a team October 8, 2023 15:04
@fzhao99 fzhao99 temporarily deployed to dev5 October 10, 2023 14:22 — with GitHub Actions Inactive
@fzhao99
Copy link
Contributor

fzhao99 commented Oct 10, 2023

deploying this to dev5 for testing just kidding apparently smarty is broken in 5 deploying on dev2 instead

huh ok so the major release seems to actually be breaking our smarty implementation in lowers. Getting this console error

InstrumentHooks.js:93 Refused to connect to https://us-zipcode.api.smarty.com/lookup?zipcode=%5BREDACTED%5D&agent=smarty+(sdk:javascript%403.2.0)&key=%5BREDACTED%5D because it violates the following Content Security Policy directive: "connect-src 'self' https://us-street.api.smartystreets.com https://us-zipcode.api.smartystreets.com www.google-analytics.com https://touchpoints.app.cloud.gov https://dc.services.visualstudio.com/v2/track https://*.applicationinsights.azure.com https://dev2.simplereport.gov/api/".

It seems that SmartyStreets has rebranded to Smarty and changed all their API urls and we need to update our CSP settings to match.

@fzhao99 fzhao99 temporarily deployed to dev5 October 10, 2023 14:33 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to dev2 October 10, 2023 16:06 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to dev2 October 10, 2023 16:31 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to dev2 October 10, 2023 20:31 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to dev2 October 10, 2023 20:43 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed on dev2 and things seem to be working!

Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev2 and it worked as expected. Thanks Bob!

@fzhao99 fzhao99 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 7fc103e Oct 11, 2023
@fzhao99 fzhao99 deleted the dependabot/npm_and_yarn/frontend/smartystreets-javascript-sdk-3.2.0 branch October 11, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants