Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up rsv feature flag #6827

Merged
merged 3 commits into from
Oct 24, 2023
Merged

clean up rsv feature flag #6827

merged 3 commits into from
Oct 24, 2023

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Oct 24, 2023

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Cleans up the RSV feature flag now that the feature is live in prod

Testing

Make sure there aren't any regressions on the following pages (and that I haven't missed anything)

  • Admin select screen (RSV selectable in the "additional diseases" options in device management)

Screenshot 2023-10-24 at 10 26 38 AM

  • In the test result uploader (we should be able to submit RSV results now)

Uploaded the following CSV and got the following result. Notice the 4 vs 3 result count between UP and COVID-only that indicates that we've submitted an RSV result

patient_id,patient_last_name,patient_first_name,patient_middle_name,patient_street,patient_street2,patient_city,patient_state,patient_zip_code,patient_county,patient_phone_number,patient_dob,patient_gender,patient_race,patient_ethnicity,patient_preferred_language,patient_email,accession_number,equipment_model_name,test_performed_code,test_result,order_test_date,specimen_collection_date,testing_lab_specimen_received_date,test_result_date,date_result_released,specimen_type,ordering_provider_id,ordering_provider_last_name,ordering_provider_first_name,ordering_provider_middle_name,ordering_provider_street,ordering_provider_street2,ordering_provider_city,ordering_provider_state,ordering_provider_zip_code,ordering_provider_phone_number,testing_lab_clia,testing_lab_name,testing_lab_street,testing_lab_street2,testing_lab_city,testing_lab_state,testing_lab_zip_code,testing_lab_phone_number,pregnant,employed_in_healthcare,symptomatic_for_disease,illness_onset_date,resident_congregate_setting,residence_type,hospitalized,icu,ordering_facility_name,ordering_facility_street,ordering_facility_street2,ordering_facility_city,ordering_facility_state,ordering_facility_zip_code,ordering_facility_phone_number,comment,test_result_status
1234,Doe,Jane,,123 Main St,,Birmingham,AL,35226,Jefferson,205-999-2800,1/20/1962,F,White,Not Hispanic or Latino,,,42daf9c8-9deb-4636-a040-380bde2b44cd,BinaxNOW COVID-19 Ag Card,94558-4,Detected,12/20/2021 14:00,12/20/2021 14:00,12/20/2021 14:00,12/20/2021 14:00,12/20/2021 14:00,Swab of internal nose,1013012657,Smith MD,John,,400 Main Street,,Birmingham,AL,35228,205-888-2000,01D1058442,My Urgent Care,400 Main Street,,Birmingham,AL,35228,205-888-2000,N,N,N,,N,,N,N,My Urgent Care,400 Main Street,Suite 100,Birmingham,AL,35228,205-888-2000,Test Comment,
P2300,Doe,Rich,,444 Hawkins Rd,,Hoover,AL,35226,Jefferson,205-333-3300,3/4/1972,F,Asian,Not Hispanic or Latino,French,,12200-A,BinaxNOW COVID-19 Ag Card,94558-4,Positive,1/5/2022 12:00,1/5/2022 12:00,1/5/2022 12:00,1/5/2022 12:00,1/5/2022 12:00,Swab of internal nose,1013012670,Jones MD,Mary,,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,01D1058443,My Urgent Care-Hoover,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,Y,N,Y,,Y,57656006,Y,N,My Urgent Care-Hoover,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,,
P2300,Doe,Rich,,444 Hawkins Rd,,Hoover,AL,35226,Jefferson,205-333-3300,3/4/1972,F,Asian,Not Hispanic or Latino,eng,,12200-B,BinaxNOW COVID-19 Ag Card,94558-4,Negative,1/5/2022 15:00,1/5/2022 15:00,1/5/2022 15:00,1/5/2022 15:00,1/5/2022 15:00,Swab of internal nose,1013012670,Jones MD,Mary,,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,01D1058443,My Urgent Care-Hoover,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,N,N,Y,,Y,Hospital,Y,N,My Urgent Care-Hoover,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,,
P2300,Doe,Rich,,444 Hawkins Rd,,Hoover,AL,35226,Jefferson,205-333-3300,3/4/1972,F,Asian,Not Hispanic or Latino,eng,,12200-B,BinaxNOW COVID-19 Ag Card,94558-5,Negative,1/5/2022 15:00,1/5/2022 15:00,1/5/2022 15:00,1/5/2022 15:00,1/5/2022 15:00,Swab of internal nose,1013012670,Jones MD,Mary,,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,01D1058443,My Urgent Care-Hoover,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,N,N,Y,,Y,Hospital,Y,N,My Urgent Care-Hoover,800 Doctors Way,,Birmingham,AL,35244,205-888-2300,,
Screen.Recording.2023-10-24.at.10.42.24.AM.mov

Verify also that the tests that got changed have been refactored correctly

@fzhao99 fzhao99 changed the title remove rsv from diseases clean up rsv feature flag Oct 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@fzhao99 fzhao99 marked this pull request as ready for review October 24, 2023 14:46
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up looks good! 🧹

@fzhao99 fzhao99 added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 908d258 Oct 24, 2023
33 checks passed
@fzhao99 fzhao99 deleted the bob/6497-clean-up-rsv-ff branch October 24, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up feature flag for RSV in bulk uploader (rsv-enabled)
3 participants