Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix backend start for e2e #6841

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix backend start for e2e #6841

merged 3 commits into from
Oct 25, 2023

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Oct 25, 2023 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

  • E2E tests and Light House are waiting the full time for the backend to be up because it is not expecting the http response to have a body. The only reason why this works today is the check to determine to end the script cannot compare an integer (200) with the response string.

Changes Proposed

  • Expect the http response to contain "UP"

Additional Information

Testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BobanL BobanL marked this pull request as ready for review October 25, 2023 17:12
johanna-skylight
johanna-skylight approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! LGTM

alismx
alismx approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@alismx alismx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alismx alismx added this pull request to the merge queue Oct 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2023
@BobanL BobanL added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 7dfabfb Oct 25, 2023
32 checks passed
@BobanL BobanL deleted the boban/fix-e2e-backend-start branch October 25, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@alismx alismx alismx approved these changes

@zdeveloper zdeveloper Awaiting requested review from zdeveloper

@mehansen mehansen Awaiting requested review from mehansen

@emyl3 emyl3 Awaiting requested review from emyl3

@fzhao99 fzhao99 Awaiting requested review from fzhao99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobanL @alismx @johanna-skylight