Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependabot): update reviewers and add new package ecosystem for… #6895

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore(dependabot): update reviewers and add new package ecosystem for… #6895

merged 1 commit into from
Nov 17, 2023

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Nov 1, 2023 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

This Pull Request:

  • Adds a review segment for Docker files in the root directory.
  • Adjust the reviewers.
  • Removes Alis and Rin as hard-coded reviewers across all package ecosystems.

This change aims to streamline the review process by specifying teams rather than individual users.

Additional Information

We need to create a team cdcgov/simplereport-devsecopsreviews.

Testing

This PR changes the configuration and does not introduce changes to the application's functionality. Validation requires monitoring future Dependabot PRs to observe if they align with the new configurations.

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@alismx alismx marked this pull request as ready for review November 1, 2023 18:41
BobanL
BobanL previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

emyl3
emyl3 previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alismx
Copy link
Collaborator Author

alismx commented Nov 16, 2023

This will be reworked to match the expectations set in SR eng sync.

@alismx alismx marked this pull request as draft November 16, 2023 21:08
@alismx alismx dismissed stale reviews from emyl3 and BobanL via 598cbd1 November 16, 2023 23:43
@alismx alismx marked this pull request as ready for review November 17, 2023 18:52
@alismx alismx requested review from BobanL, a team, emyl3 and mehansen and removed request for BobanL, rin-skylight, a team, mehansen, DanielSass and emyl3 November 17, 2023 18:52
@alismx alismx requested review from DanielSass and BobanL and removed request for BobanL November 17, 2023 18:58
@fzhao99 fzhao99 self-requested a review November 17, 2023 19:22
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

emyl3
emyl3 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alismx alismx added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit f7685fc Nov 17, 2023
33 checks passed
@alismx alismx deleted the alis/6894 branch November 17, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@BobanL BobanL BobanL left review comments

@mehansen mehansen Awaiting requested review from mehansen mehansen was automatically assigned from CDCgov/simplereport-engineeringreviews

@DanielSass DanielSass Awaiting requested review from DanielSass DanielSass was automatically assigned from CDCgov/simplereport-engineeringreviews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reviewers for dependabot
4 participants
@alismx @BobanL @emyl3 @fzhao99