Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boban/fix corrected result #6897

Closed
wants to merge 7 commits into from
Closed

Boban/fix corrected result #6897

wants to merge 7 commits into from

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Nov 1, 2023 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

  • When a result gets corrected, both show up on the results list. In the case of marking it as "duplicated", the result still shows up.
Screenshare.-.2023-10-30.3_40_01.PM.mp4

Changes Proposed

  • Join Result with Test Order to ensure only the latest results appear.
  • Add a new variable name "testEventId" in result to make it easier to understand what the ID should be.

Additional Information

  • Results are either associated with test events or test orders. A test event does not have any information to determine if it is the latest test event in an order.
  • A follow up ticket will be added to remove the "id" field from TestResultsRow.

Testing

  • Deployed to dev3
  • Ensure that corrected results do not show up twice on the result table and duplicated results get crossed out.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

65.5% 65.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@BobanL BobanL temporarily deployed to dev3 November 1, 2023 20:15 — with GitHub Actions Inactive
@BobanL BobanL temporarily deployed to dev3 November 1, 2023 20:22 — with GitHub Actions Inactive
@zdeveloper zdeveloper mentioned this pull request Nov 3, 2023
Merged
@BobanL BobanL closed this Nov 3, 2023
@BobanL BobanL deleted the boban/fix-corrected-result branch November 3, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BobanL