Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add equipment uid type to admin device management #6898

Merged
merged 4 commits into from
Nov 2, 2023
Merged

add equipment uid type to admin device management #6898

merged 4 commits into from
Nov 2, 2023

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Nov 1, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds a field for equipment UID type to the admin device management page.
  • Clean up some of the labels for that section so the layout doesn't get pushed around

Testing

deployed on dev 5

  • Make sure you can add a device / edit it with the extra field

Screenshots / Demos

Editing
https://github.com/CDCgov/prime-simplereport/assets/29645040/bbc9814d-4a6b-4587-91c1-9659935a27b8

Adding
https://github.com/CDCgov/prime-simplereport/assets/29645040/27ac65b7-d254-4b24-8257-21b276a4b48f

@fzhao99 fzhao99 changed the title Bob/6809 add equipment uid type to device management add equipment uid type to admin device management Nov 1, 2023
@fzhao99 fzhao99 temporarily deployed to dev5 November 1, 2023 20:06 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to dev5 November 1, 2023 20:13 — with GitHub Actions Inactive
@fzhao99 fzhao99 marked this pull request as ready for review November 1, 2023 20:27
BobanL
BobanL previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but would it be possible to rename "Supported Disease *" to just "Disease *" so it doesn't push the * down to a new line?
image

@fzhao99 fzhao99 temporarily deployed to dev5 November 2, 2023 14:30 — with GitHub Actions Inactive
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@fzhao99 fzhao99 temporarily deployed to dev5 November 2, 2023 14:37 — with GitHub Actions Inactive
@fzhao99 fzhao99 requested a review from BobanL November 2, 2023 15:18
@fzhao99
Copy link
Contributor Author

fzhao99 commented Nov 2, 2023

Changes look good, but would it be possible to rename "Supported Disease *" to just "Disease *" so it doesn't push the * down to a new line? image

Fixed!
Screenshot 2023-11-02 at 11 21 57 AM

johanna-skylight
johanna-skylight approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯 thanks Bob!

@fzhao99 fzhao99 added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit a685331 Nov 2, 2023
37 checks passed
@fzhao99 fzhao99 deleted the bob/6809-add-equipment-uid-type-to-device-management branch November 2, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@BobanL BobanL BobanL approved these changes

@emyl3 emyl3 Awaiting requested review from emyl3

@mehansen mehansen Awaiting requested review from mehansen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add equipment UID type to device management frontend
3 participants
@fzhao99 @BobanL @johanna-skylight