Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added style to add external link icon and text for sr #6903

Merged

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Nov 3, 2023

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Include css styling that adds the external link icon to all anchor elements that point to an external site.

Testing

Verify all links that point to an external site display the external icon.

Screenshots / Demos

Screenshot 2023-11-03 at 2 34 39 PM

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on dev5! Thank you!!

@johanna-skylight johanna-skylight added this pull request to the merge queue Nov 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2023
@johanna-skylight johanna-skylight added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit acd94b7 Nov 6, 2023
37 checks passed
@johanna-skylight johanna-skylight deleted the johanna/5857_add_external_link_style_across_app branch November 6, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add external link disclaimers to the upload result guide
4 participants