Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default nose location / description to fhir bundle #6955

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Nov 13, 2023

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds a default specimen collection location code and description to the FHIR bundle to align with the implementation in the COVID pipeline

Additional Information

Testing

  • A branch with an extra log statement is deployed to dev5.
  • Verify that extra snippet is added to the FHIR bundle by default (can use the below CSV to do so)

dev5 Boban's Org bulk upload.csv

## Running this query in Azure...
traces
| where message has "BUNDLE WITH EXTRA VALUES"

## Should give you a bundle with ... 
"bodySite" : {
    "coding" : [
      {
        "system" : "http://snomed.info/sct",
        "code" : "53342003"
      }
    ],
    "text" : "Internal nose structure (body structure)"
  }

@fzhao99 fzhao99 force-pushed the bob/6930-collection-location-code branch from dabce3c to 443aae0 Compare November 15, 2023 16:16
@fzhao99 fzhao99 marked this pull request as ready for review November 15, 2023 16:29
emyl3
emyl3 previously approved these changes Nov 15, 2023
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on dev5 -- LGTM!

Copy link

sonarqubecloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@fzhao99 fzhao99 requested review from mehansen and emyl3 November 16, 2023 15:30
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on dev5 and LGTM!

@fzhao99 fzhao99 added this pull request to the merge queue Nov 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2023
@fzhao99 fzhao99 added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit c954522 Nov 17, 2023
32 checks passed
@fzhao99 fzhao99 deleted the bob/6930-collection-location-code branch November 17, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default location code in FHIR bundles to match Covid messages
4 participants