-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bob/6936 query for admin emails #6962
Conversation
backend/src/main/java/gov/cdc/usds/simplereport/service/OrganizationService.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/gov/cdc/usds/simplereport/service/OrganizationServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deployed and tested on dev7 -- would love your thoughts on a comment I left! Thank you, Bob!
backend/src/main/java/gov/cdc/usds/simplereport/service/OrganizationService.java
Fixed
Show fixed
Hide fixed
backend/src/test/java/gov/cdc/usds/simplereport/service/OrganizationServiceTest.java
Fixed
Show fixed
Hide fixed
Kudos, SonarCloud Quality Gate passed! |
return foundUser.getInternalId(); | ||
Optional<ApiUser> foundUser = apiUserRepository.findByLoginEmail(email); | ||
if (foundUser.isEmpty()) { | ||
log.warn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this change! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! tested on dev7 with the org that was erroring before and got back user ids 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work on this, I like the warning about a user in Okta but not the database
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Testing
This is the query that I setup in Postman in case it's helpful
Screen.Recording.2023-11-15.at.4.18.01.PM.mov
deployed on dev3 and got the following return for Boban's org