Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missed cert id #7092

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update missed cert id #7092

merged 2 commits into from
Dec 14, 2023

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Dec 14, 2023 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Hardcode the missed instance of key_vault_secret_id

Testing

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@alismx alismx marked this pull request as ready for review December 14, 2023 19:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

emyl3
emyl3 reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question for you alis!

ops/prod/app_gateway_url_redirects.tf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to change the values on line 341, 345, and 346 on this file as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! That's a difference cert that I rotated last month; it doesn't apply in this case. 😄

@alismx alismx added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit e231cad Dec 14, 2023
46 checks passed
@alismx alismx deleted the alis/hardcode_wildcard branch December 14, 2023 20:02
@alismx alismx mentioned this pull request Dec 15, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 left review comments

@fzhao99 fzhao99 fzhao99 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alismx @emyl3 @mpbrown @fzhao99