Support HIV on Results and PXP pages #7161

emyl3 · 2024-01-13T00:32:23Z

FRONTEND PULL REQUEST

Related Issue

Resolves HIV on results page and PXP #7077

Changes Proposed

Displays HIV in the Test Results page "Condition" filter when hivEnabled feature flag is on

Display "HIV result" in CSV when clicking "Download results"

Print modal displays HIV results

View details includes HIV results and AOE questions (pregnant and gender of sexual partners)

PXP page of a HIV test result

Additional Information

This PR does not address copy for the "More information" section or its translation for pxp test results and print pages (covered in [Placeholder] Update copy for HIV on results page #7080)

Testing

available on dev2 for testing

Screenshots / Demos

Please see above

emyl3 · 2024-01-13T00:54:22Z

frontend/src/app/utils/testResults.ts

@@ -56,6 +56,20 @@ export function hasCovidResults(results: MultiplexResults): boolean {
  );
 }

+export function hasDiseaseSpecificResults(


⚠️ eventually we can refactor to use this instead of the covid specific version on line 51

emyl3 · 2024-01-13T00:56:18Z

frontend/src/lang/es.ts

@@ -40,6 +40,7 @@ export const es: LanguageConfig = {
        FLUA: "Flu A",
        FLUB: "Flu B",
        RSV: "VRS",
+        HIV: "VIH",


⚠️ got VIH from the CDC's usage of it

emyl3 · 2024-01-13T01:33:55Z

frontend/src/app/testResults/viewResults/actionMenuModals/TestResultDetailsModal.tsx

@@ -42,40 +50,6 @@ type Result = {
  };
 };

-export const testResultDetailsQuery = gql`


⚠️ moved to separate operations.graphql file

emyl3 · 2024-01-16T22:26:44Z

frontend/src/app/testResults/viewResults/actionMenuModals/TestResultDetailsModal.tsx

-            removed={removed}
-            aria-describedby="result-detail-title"
-          />
+          {!isHIVResult && (


⚠️ We are currently not collecting this for HIV results so symptoms and symptom onset date will only be displayed if it is not a HIV result

emyl3 · 2024-01-16T22:58:42Z

frontend/src/app/testResults/viewResults/operations.graphql

+    symptoms
+    symptomOnset
+    pregnancy
+    genderOfSexualPartners


⚠️ added genderOfSexualPartners so it can be displayed

frontend/src/app/utils/testResults.ts

fzhao99 · 2024-01-17T14:08:01Z

frontend/src/app/utils/gender.ts

@@ -0,0 +1,25 @@
+import { UNKNOWN } from "../../lang/en";


I think we might be able to use some TS language features to make this file more robust. I put together a playground link here

Let me know if you want to chat through anything since there are a couple TS nerdery things that I pulled together to make the above work

@fzhao99 I like that idea of using a typed dictionary for the gender values (non-blocking if we wanna have that in a separate PR). Saw this comment too which makes me wonder if there's any particular reason the test result details are not currently translated?

OOO thank you for nerding out! love that -- will take a look now! 👀

fzhao99 · 2024-01-17T14:23:34Z

frontend/src/lang/en.ts

+const MALE = "Male";
+const TRANSWOMAN = "Trans femme or transwoman";
+const TRANSMAN = "Trans masculine or transman";
+const NONBINARY = "Nonbinary or gender non-conforming";


Extending on this comment, would love to couple these constants here with the value of the GenderIdentities dictionary we're defining so that there's one source of truth for these strings. Worry that we might have string drift if we redefine the constants here

Think we could replace these with GenderIdentityDisplay.female, GenderIdentityDisplay.male, etc. so that the dictionary in the format file is the source of truth for what the strings are.

mpbrown

LGTM! Thanks for tidying up some of the graphql!

mpbrown · 2024-01-17T16:28:37Z

frontend/src/app/utils/gender.ts

@@ -0,0 +1,25 @@
+import { UNKNOWN } from "../../lang/en";


@fzhao99 I like that idea of using a typed dictionary for the gender values (non-blocking if we wanna have that in a separate PR). Saw this comment too which makes me wonder if there's any particular reason the test result details are not currently translated?

sonarqubecloud · 2024-01-17T20:24:49Z

Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

emyl3 · 2024-01-17T23:45:39Z

@fzhao99 and @mpbrown Ready for re-review! The checks are not all successful because the sonarcloud one is failing for no test coverage which is not true 😅

emyl3 commented Jan 13, 2024

View reviewed changes

emyl3 force-pushed the elisa/7077-hiv-results-pxp branch from b324f9d to 2336d2e Compare January 13, 2024 01:22

emyl3 commented Jan 13, 2024

View reviewed changes

emyl3 temporarily deployed to dev2 January 13, 2024 02:15 — with GitHub Actions Inactive

emyl3 temporarily deployed to dev2 January 13, 2024 02:21 — with GitHub Actions Inactive

emyl3 commented Jan 16, 2024

View reviewed changes

Support HIV on Results and PXP pages

2fdcfda

emyl3 force-pushed the elisa/7077-hiv-results-pxp branch from 2336d2e to 2fdcfda Compare January 16, 2024 22:30

emyl3 commented Jan 16, 2024

View reviewed changes

emyl3 temporarily deployed to dev2 January 16, 2024 23:25 — with GitHub Actions Inactive

emyl3 temporarily deployed to dev2 January 16, 2024 23:31 — with GitHub Actions Inactive

emyl3 marked this pull request as ready for review January 16, 2024 23:45

emyl3 requested review from mehansen, DanielSass, mpbrown and fzhao99 January 16, 2024 23:45

fzhao99 reviewed Jan 17, 2024

View reviewed changes

frontend/src/app/utils/testResults.ts Outdated Show resolved Hide resolved

fzhao99 reviewed Jan 17, 2024

View reviewed changes

mpbrown previously approved these changes Jan 17, 2024

View reviewed changes

Address feedback

b2285d9

emyl3 dismissed mpbrown’s stale review via b2285d9 January 17, 2024 19:41

emyl3 temporarily deployed to dev2 January 17, 2024 21:05 — with GitHub Actions Inactive

emyl3 temporarily deployed to dev2 January 17, 2024 21:11 — with GitHub Actions Inactive

emyl3 requested review from fzhao99 and mpbrown January 17, 2024 23:44

fzhao99 approved these changes Jan 18, 2024

View reviewed changes

mpbrown approved these changes Jan 19, 2024

View reviewed changes

emyl3 added this pull request to the merge queue Jan 19, 2024

Merged via the queue into main with commit 37f25f7 Jan 19, 2024
40 of 41 checks passed

emyl3 deleted the elisa/7077-hiv-results-pxp branch January 19, 2024 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support HIV on Results and PXP pages #7161

Support HIV on Results and PXP pages #7161

emyl3 commented Jan 13, 2024 •

edited by fzhao99

Loading

emyl3 Jan 13, 2024

emyl3 Jan 13, 2024

emyl3 Jan 13, 2024

emyl3 Jan 16, 2024

emyl3 Jan 16, 2024

fzhao99 Jan 17, 2024 •

edited

Loading

mpbrown Jan 17, 2024

emyl3 Jan 17, 2024

fzhao99 Jan 17, 2024

mpbrown left a comment

mpbrown Jan 17, 2024

sonarqubecloud bot commented Jan 17, 2024

emyl3 commented Jan 17, 2024

Support HIV on Results and PXP pages #7161

Support HIV on Results and PXP pages #7161

Conversation

emyl3 commented Jan 13, 2024 • edited by fzhao99 Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

Additional Information

Testing

Screenshots / Demos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fzhao99 Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpbrown left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 17, 2024

Quality Gate failed

emyl3 commented Jan 17, 2024

emyl3 commented Jan 13, 2024 •

edited by fzhao99

Loading

fzhao99 Jan 17, 2024 •

edited

Loading