Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SensitiveTopicsTooltipModal more composable #8256

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Make SensitiveTopicsTooltipModal more composable #8256

merged 1 commit into from
Nov 6, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Oct 31, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Updates SensitiveTopicsTooltipModal so that components using it can choose which AOE questions they want to display the explanations for

Additional Information

  • Will follow up to refactor other AOE form components so that where possible they use the reusable aoeQuestionComponents

Testing

  • Deployed on dev4

@mpbrown mpbrown force-pushed the mike/refactor-sensitive-topics-modal branch from e2447ee to f1d1da0 Compare November 5, 2024 18:43
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpbrown mpbrown marked this pull request as ready for review November 5, 2024 22:24
DavidMcClatchey
DavidMcClatchey approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@DavidMcClatchey DavidMcClatchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

emyl3
emyl3 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work refactoring this, Mike!

@mpbrown mpbrown added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 3cc7495 Nov 6, 2024
42 checks passed
@mpbrown mpbrown deleted the mike/refactor-sensitive-topics-modal branch November 6, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMcClatchey DavidMcClatchey DavidMcClatchey approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@bobbywells52 bobbywells52 Awaiting requested review from bobbywells52

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpbrown @emyl3 @DavidMcClatchey