Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hepatitis C support for bulk upload #8269

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Nov 5, 2024

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Supports the bulk upload of Hepatitis C test results
  • Throws a validation error if user tries to upload a positive Hepatitis C result without the required AOE columns (pregnancy, gender_of_sexual_partners, symptomatic_for_disease)

Additional Information

  • N/A

Testing

@emyl3 emyl3 force-pushed the elisa/7449-hepc-bulk-uploader branch from e52e1da to 85619a1 Compare November 5, 2024 23:15
@emyl3 emyl3 force-pushed the elisa/7449-hepc-bulk-uploader branch from 85619a1 to 663d99b Compare November 6, 2024 16:35
Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM testing it on dev3!

non-blocking, but I did notice a small styling bug for errors where there isn't formatting for the title of the pregnant column like there is for symptomatic_for_disease and genders_of_sexual_partners

Screenshot 2024-11-07 121155

@emyl3
Copy link
Collaborator Author

emyl3 commented Nov 7, 2024

LGTM testing it on dev3!

non-blocking, but I did notice a small styling bug for errors where there isn't formatting for the title of the pregnant column like there is for symptomatic_for_disease and genders_of_sexual_partners

Screenshot 2024-11-07 121155

Looks like this is a bug on the frontend -- I'll put up a separate PR fix for this!

Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both a valid and invalid entry on dev3 and both are working as expected -- LGTM! Thanks for your great work on this!

@emyl3 emyl3 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit ecea76f Nov 8, 2024
38 checks passed
@emyl3 emyl3 deleted the elisa/7449-hepc-bulk-uploader branch November 8, 2024 19:20
@emyl3
Copy link
Collaborator Author

emyl3 commented Nov 12, 2024

@mpbrown Opened a bug report here because it was going to be a bit of a larger lift than a one line fix 😅 #8278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV Bulk Results Uploader supports Hepatitis-C test results
3 participants