Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patient gender identity to bulk upload #8270

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add patient gender identity to bulk upload #8270

merged 1 commit into from
Nov 8, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Nov 6, 2024 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds patient_gender_identity column as an optional field on the bulk results uploader

Testing

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpbrown mpbrown marked this pull request as ready for review November 6, 2024 23:05
bobbywells52
bobbywells52 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev5 and works for me!

emyl3
emyl3 reviewed Nov 8, 2024
View reviewed changes
backend/src/main/java/gov/cdc/usds/simplereport/api/model/filerow/TestResultRow.java
@@ -54,7 +55,17 @@ public class TestResultRow implements FileRow {
final ValueOrError patientCounty;
final ValueOrError patientPhoneNumber;
final ValueOrError patientDob;

/**
* This field "patient_gender" refers to the patient's sex assigned at birth. <br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this note!

emyl3
emyl3 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared this fhir bundle (when we do a bulk upload) with the one created when we submit a single entry test event and the gender identity has the same shape!

LGTM!

@mpbrown mpbrown added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit b28f0c0 Nov 8, 2024
39 checks passed
@mpbrown mpbrown deleted the mike/8224-csv-patient-gender-identity branch November 8, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add patient gender identity field to bulk results uploader
3 participants
@mpbrown @emyl3 @bobbywells52