Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prod device sync related secrets to tf configs #8323

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add prod device sync related secrets to tf configs #8323

merged 1 commit into from
Dec 3, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Nov 26, 2024 •
edited
Loading

BACKEND & DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Adds the following references to our secrets in our Azure key vault in all the terraform files
    • simple-report-prod-backend-url
    • simple-report-prod-devices-token

Additional Information

  • This works allows us to protect the soon-to-be-added public prod device sync related endpoints
  • The token will be passed as part of the request headers

Testing

  • Navigate to our Azure key vault and ensure the keys and values are there as expected

@emyl3 emyl3 force-pushed the elisa/7492-add-secret-refs branch from 57dc672 to 6fce2f8 Compare November 27, 2024 16:16
@emyl3 emyl3 mentioned this pull request Nov 27, 2024
Open
@emyl3 emyl3 force-pushed the elisa/7492-add-secret-refs branch from 6fce2f8 to d61bba7 Compare November 27, 2024 17:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emyl3 emyl3 marked this pull request as ready for review November 29, 2024 15:17
mpbrown
mpbrown approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shanice-skylight
shanice-skylight approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@shanice-skylight shanice-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the ops files and verified the terraform plan matches changes. LGTM

@emyl3 emyl3 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit a5afa4c Dec 3, 2024
38 checks passed
@emyl3 emyl3 deleted the elisa/7492-add-secret-refs branch December 3, 2024 15:46
@emyl3 emyl3 mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanice-skylight shanice-skylight shanice-skylight approved these changes

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen mehansen approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emyl3 @mehansen @mpbrown @bobbywells52 @shanice-skylight