Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maintenance banner width bug #8342

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Fix maintenance banner width bug #8342

merged 3 commits into from
Dec 5, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Dec 4, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Fixes the maintenance banner width on the app so that the color extends across the entire screen while also staying aligned with the rest of the page content

Testing

  • Deployed on dev5 with maintenance banner

Screenshots / Demos

Screenshot 2024-12-04 111043
Screenshot 2024-12-04 185244
Screenshot 2024-12-04 185253

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mpbrown mpbrown marked this pull request as ready for review December 5, 2024 12:52
emyl3
emyl3 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this, Mike!

unrelated but while testing I noticed the maintenance banner is not active for pxp and sign up pages -- I can create a ticket for that!

Screenshot 2024-12-05 at 09 25 09 Screenshot 2024-12-05 at 09 26 30

@emyl3 emyl3 mentioned this pull request Dec 5, 2024
Open
@emyl3
Copy link
Collaborator

emyl3 commented Dec 5, 2024

Ticket here: #8344

bobbywells52
bobbywells52 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Mike!

@mpbrown mpbrown added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 56975a0 Dec 5, 2024
44 checks passed
@mpbrown mpbrown deleted the mike/8248-maintenance-banner-width branch December 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Maintenance banner UI bug
3 participants
@mpbrown @emyl3 @bobbywells52