Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use var instead of const #8360

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Use var instead of const #8360

merged 1 commit into from
Dec 16, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Dec 12, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

  • Running this locally was causing this runtime error to appear
Screenshot 2024-12-12 at 15 38 39

Changes Proposed

  • Touchpoints form modal should open as expected

Additional Information

Testing

  • Running app locally should no longer show runtime error

Screenshots / Demos

Screenshot 2024-12-12 at 17 25 06

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emyl3 emyl3 marked this pull request as ready for review December 12, 2024 23:27
mpbrown
mpbrown approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM locally!

@emyl3 emyl3 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit f939996 Dec 16, 2024
44 checks passed
@emyl3 emyl3 deleted the elisa/use-var branch December 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

@arinkulshi-skylight arinkulshi-skylight Awaiting requested review from arinkulshi-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyl3 @mpbrown @bobbywells52