Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize Post Processing #55

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Modularize Post Processing #55

merged 8 commits into from
Oct 21, 2024

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Oct 15, 2024

This is a draft PR until my requested feature in renv is added. It is already in an open PR: rstudio/renv#2018

The renv bit is just required for local development (and I could come up with a workaround if required). The modularized R script should already work in an azure context.

Closes #40

@damonbayer damonbayer changed the title Modularize Post Porcessing Modularize Post Processing Oct 15, 2024
@damonbayer
Copy link
Collaborator Author

Because of #66 I would be Willing to merge this now. I have a workaround for the part that is dependent on the renv update.

@damonbayer damonbayer marked this pull request as ready for review October 21, 2024 14:07
Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thought.

nssp_demo/post_process.R Show resolved Hide resolved
nssp_demo/post_process.R Show resolved Hide resolved
@dylanhmorris
Copy link
Contributor

@damonbayer will let you merge

@damonbayer damonbayer merged commit cc7f156 into main Oct 21, 2024
1 check passed
@damonbayer damonbayer deleted the dmb_modularize_post_process branch October 21, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally prune bad chains in post-processing
2 participants