Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overflow #3

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Prevent overflow #3

merged 3 commits into from
Feb 28, 2025

Conversation

swo
Copy link
Contributor

@swo swo commented Feb 28, 2025

  • Fix math in some equations
  • Define the $h$ function
  • Use the $h$ function on the backend to avoid overflows related to factorials

Note that there is still numerical instability at higher $k$ and $n$

@swo swo marked this pull request as ready for review February 28, 2025 00:27
@swo swo merged commit cd3ddf2 into main Feb 28, 2025
3 checks passed
@swo swo deleted the swo_overflow branch February 28, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant