-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Toast Messaging capabilities to the app #222
Merged
jupiter007
merged 16 commits into
development
from
spike/JS-research-toast-message-options
Jan 10, 2025
Merged
Added Toast Messaging capabilities to the app #222
jupiter007
merged 16 commits into
development
from
spike/JS-research-toast-message-options
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briri
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks great @jupiter007 |
fraserclark
approved these changes
Jan 10, 2025
Thanks @fraserclark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made sure to position the toast messages differently for desktop and mobile. The locations can always be adjusted.
We can pass the keys 'info', 'success' and 'error' to the toast message to get different colors.
The width of the toast message fits the text up to 50% of the screen width currently. This is all totally adjustable, and we can change it later if we feel the need.
Fixes # (211)
Type of change
How Has This Been Tested?
Tested this manually.
Checklist:
Toast Messaging demo
For smaller devices, the toast message should display towards the bottom of the screen, and for larger devices towards the top of the screen.
Screen.Recording.2025-01-09.at.8.34.20.AM.mov