Integrate ProcessedBsm #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully integrates the new ProcessedBsm data structure into the Conflict Monitor's data processing.
Removes all dependence on the
OdeBsmDataclass and on the ODE raw BSM Kafka topics, and instead reads fromtopic.ProcessedBsm. Updates all logic that formerly used raw BSMs to useProcessedBsms instead.Removes the Repartition topology which is no longer needed because the
topic.ProcessedBsmstream is pre-partitioned. Changes the BSM key and partitioning to useRsuLogKeyto match what the Geojson Converter produces.Tests
This PR was tested by verifying that the unit tests pass, and by running the following integration test scripts involving BSMs and verifying that they still produce the expected events:
Script-BSMs.csv- BSM path EventsBSM_Revisions.csv- Aggregated BSM Message Count Progression EventsConnectionOfTravel-connected.csv,ConnectionOfTravel-u-turn.csv- Connection of Travel, Lane Direction of Travel, and Stop Line Passage EventsApproachAndStopAtLine.csv- Stop Line Stop Events