Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSU Errors Page #104

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

RSU Errors Page #104

wants to merge 11 commits into from

Conversation

mwodahl
Copy link
Collaborator

@mwodahl mwodahl commented Sep 17, 2024

PR Details

This PR Adds an RSU Errors page to the map view of the cv-manager.

Description

This new RSU Errors page shows the online status and SCMS status of an RSU in table format and allows users to navigate to the RSU on the map. Additionally, users can generate a summary email for the RSU that includes the current errors and UTC timestamp.

How Has This Been Tested?

This has been tested by running the cv-manager locally using Docker.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • [ X ] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • [ X ] My changes require updates and/or additions to the unit tests:
    • [ X ] I have modified/added tests to cover my changes.
  • [ X ] All existing tests pass.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks really good as a first swing at it! The email feature seems super useful but a little limited in the current implementation. Manually finding an RSU with an error and manually having the CV Manager send an email for that one RSU seems a little pointless to me. If there was a way to include all RSUs with issues or to generate a full report as PDF it might save the user time and be a little less tedious.

webapp/src/features/menu/DisplayRsuErrors.tsx Outdated Show resolved Hide resolved
@mwodahl
Copy link
Collaborator Author

mwodahl commented Oct 2, 2024

Updated all of the display text on this new component to 'RSU Status' instead of 'RSU Errors' and added PDF generation for both the full RSU report and the RSU error report.

@mwodahl mwodahl requested a review from drewjj October 2, 2024 14:14
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and is going to be incredibly useful for the user experience. All tests pass too.

Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question regarding formatting to remove the scrollbar
image
Otherwise looks awesome!

@mwodahl
Copy link
Collaborator Author

mwodahl commented Oct 17, 2024

Removed variable page length options from the RSU Status table so there isn't a horizontal scrollbar on the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants