-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSU Errors Page #104
base: develop
Are you sure you want to change the base?
RSU Errors Page #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks really good as a first swing at it! The email feature seems super useful but a little limited in the current implementation. Manually finding an RSU with an error and manually having the CV Manager send an email for that one RSU seems a little pointless to me. If there was a way to include all RSUs with issues or to generate a full report as PDF it might save the user time and be a little less tedious.
Updated all of the display text on this new component to 'RSU Status' instead of 'RSU Errors' and added PDF generation for both the full RSU report and the RSU error report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and is going to be incredibly useful for the user experience. All tests pass too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed variable page length options from the RSU Status table so there isn't a horizontal scrollbar on the footer. |
PR Details
This PR Adds an RSU Errors page to the map view of the cv-manager.
Description
This new RSU Errors page shows the online status and SCMS status of an RSU in table format and allows users to navigate to the RSU on the map. Additionally, users can generate a summary email for the RSU that includes the current errors and UTC timestamp.
How Has This Been Tested?
This has been tested by running the cv-manager locally using Docker.
Types of changes
Checklist: