Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/intersection tables #105

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

jacob6838
Copy link
Collaborator

PR Details

Description

DISCLAIMER This is not intended to be included in the current JPO-USDOT release. As such, this has been created as a Draft PR.

This PR adds the management of intersection data to the cvmanager. This includes the following:

  1. Adding postgresql tables for intersections, intersection_organizations, and rsu_intersections
  2. Adding API endpoints to handle management of intersections and links
  3. Adding webapp Admin pages for creating, editing, and removing intersections, intersection-organization links, and rsu-intersection links.

How Has This Been Tested?

These changes were tested locally, running the api, webapp, and database updates together. Through the UI, you are able to create intersections, remove intersections, edit intersections, create/remove intersection - organization links, and create/remove rsu - intersection links.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@drewjj drewjj marked this pull request as ready for review September 27, 2024 14:57
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API unit tests have some failures:

image

resources/sql_scripts/CVManager_CreateTables.sql Outdated Show resolved Hide resolved
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! The API/webapp unit tests pass & I am able to access the new UI pages through the webapp.

@jacob6838 jacob6838 requested a review from drewjj October 16, 2024 22:43
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything was put together nicely and the unit tests pass for both the webapp and api. A number of comments I would like addressed but it is very close!

@jacob6838 jacob6838 requested a review from drewjj October 17, 2024 14:37
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, everything looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants