-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/intersection tables #105
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! The API/webapp unit tests pass & I am able to access the new UI pages through the webapp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything was put together nicely and the unit tests pass for both the webapp and api. A number of comments I would like addressed but it is very close!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, everything looks great!
PR Details
Description
DISCLAIMER This is not intended to be included in the current JPO-USDOT release. As such, this has been created as a Draft PR.
This PR adds the management of intersection data to the cvmanager. This includes the following:
How Has This Been Tested?
These changes were tested locally, running the api, webapp, and database updates together. Through the UI, you are able to create intersections, remove intersections, edit intersections, create/remove intersection - organization links, and create/remove rsu - intersection links.
Types of changes
Checklist: