Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBU OTA Server FQDN Fix #117

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

OBU OTA Server FQDN Fix #117

wants to merge 2 commits into from

Conversation

Michael7371
Copy link
Collaborator

PR Details

Description

  • Updates Dockerfile to use layer caching more efficiently by installing dependencies first
  • Added logic to return firmware "href" download locations with a Fully Qualified Domain Name (FQDN) rather than emitting it
  • Adding unit tests to verify logic changes

How Has This Been Tested?

Test deploy on CDOT K8 dev cluster and in WyDOT VM deployment. Added unit tests to validate logic.

Types of changes

  • [ x ] Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • [ x ] My changes require new environment variables:
    • [ x ] I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • [ x ] My changes require updates and/or additions to the unit tests:
    • [ x ] I have modified/added tests to cover my changes.
  • [ x ] All existing tests pass.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the unit tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants