-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflictvisualizer api integration #119
base: develop
Are you sure you want to change the base?
Conversation
…o conflictvisualizer-api-integration
Do we want to continue to call the conflictvisualizer-api the conflictvisualizer-api? If all goes to plan the conflict visualizer won't really exist a year from now, so maybe best to rename it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Conflict Monitor is now a submodule of the CV Manager. Should the references to the Conflictmonitor/connect context should be updated to point to the Conflict Monitor Connect context within the submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add some optional comments for this, but think 99% of the time the pre-built image should be fine. Faster build times and less changes for build errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be deleted, and the version inside of the conflict monitor submodule be used instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, yup!
PR Details
Description
Adding the JPO-ConflictVisualizer API to the cvmanager services directory. This is a Java Spring-Boot api.
These changes are built off of the Feature/intersection-tables PR.
** Note**
When pulling this branch, you may have to enable long file paths in git:
git config --system core.longpaths true
This process is further defined in services/conflictvisualizer-api/README.md
How Has This Been Tested?
This was tested using the docker-compose.yml, after commending in the local image and build tags
Types of changes
Checklist: