With embedded iframes dont add 'javascript:' entries to 'history' - f…

…ixes back button with 'Visual Statistics' plugin.
CDrummond · Oct 9, 2021 · f58f5fd · f58f5fd
1 parent bb25bdf
commit f58f5fd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -24,6 +24,8 @@
     players' dialogs.
 16. Add player icon mapping for HTTP and Alexa.
 17. Remove note stating iPhone does not support drag'n'drop.
+18. With embedded iframes dont add 'javascript:' entries to 'history' - fixes
+    back button with 'Visual Statistics' plugin.
 
 2.6.3
 -----

diff --git a/MaterialSkin/HTML/material/html/js/iframe-dialog.js b/MaterialSkin/HTML/material/html/js/iframe-dialog.js
@@ -460,6 +460,9 @@ Vue.component('lms-iframe-dialog', {
             this.loaded = true;
         }.bind(this));
         bus.$on('iframe-href', function(ref, addToHistory) {
+            if (ref.startsWith("javascript:")) {
+                return;
+            }
             if (undefined==addToHistory || addToHistory) {
                 this.history.push(this.src);
             }