Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in sharding mode, support local transaction #255

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

dk-lockdown
Copy link
Collaborator

@dk-lockdown dk-lockdown commented Aug 19, 2022

ref: #236

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image

Check the result, update rollbacked.
image

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #255 (3a1754b) into dev (59b9ff1) will decrease coverage by 0.38%.
The diff coverage is 2.50%.

❗ Current head 3a1754b differs from pull request most recent head 77d9c3d. Consider uploading reports for the commit 77d9c3d to get more accurate results

@@            Coverage Diff             @@
##              dev     #255      +/-   ##
==========================================
- Coverage   43.77%   43.38%   -0.39%     
==========================================
  Files          82       82              
  Lines        9885     9980      +95     
==========================================
+ Hits         4327     4330       +3     
- Misses       5106     5196      +90     
- Partials      452      454       +2     
Impacted Files Coverage Δ
pkg/executor/read_write_splitting.go 46.30% <0.00%> (-0.23%) ⬇️
pkg/plan/delete.go 6.55% <0.00%> (-0.72%) ⬇️
pkg/plan/insert.go 38.18% <0.00%> (-11.82%) ⬇️
pkg/plan/query.go 34.02% <0.00%> (-2.45%) ⬇️
pkg/plan/update.go 9.52% <0.00%> (-1.01%) ⬇️
pkg/executor/sharding.go 38.09% <7.69%> (-8.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dk-lockdown dk-lockdown marked this pull request as ready for review August 22, 2022 13:51
@dk-lockdown dk-lockdown merged commit 97c5e18 into CECTC:dev Sep 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants