Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support number range sharding algorithm #262

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

dk-lockdown
Copy link
Collaborator

ref: #235

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #262 (ec165a8) into dev (4d6da29) will increase coverage by 0.03%.
The diff coverage is 33.55%.

@@            Coverage Diff             @@
##              dev     #262      +/-   ##
==========================================
+ Coverage   43.76%   43.80%   +0.03%     
==========================================
  Files          82       84       +2     
  Lines        9884    10043     +159     
==========================================
+ Hits         4326     4399      +73     
- Misses       5106     5171      +65     
- Partials      452      473      +21     
Impacted Files Coverage Δ
pkg/cond/sharding_algorithm.go 0.00% <0.00%> (-18.25%) ⬇️
pkg/topo/topo.go 75.43% <ø> (-0.43%) ⬇️
pkg/cond/algo_number_mod.go 20.00% <20.00%> (ø)
pkg/cond/algo_number_range.go 45.06% <45.06%> (ø)
pkg/executor/sharding.go 46.15% <50.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dk-lockdown dk-lockdown merged commit 5177880 into CECTC:dev Oct 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants