Fix restart/delete tasks action (#76)

* Replace restart_tasks and delete_tasks methods with the relative KartonBackend methods * Revert cancel refactor --------- Co-authored-by: Michał Praszmo <[email protected]>
CERT-Polska · Jun 20, 2023 · 00c788e · 00c788e
1 parent 9d55d8b
commit 00c788e
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/karton/dashboard/app.py b/karton/dashboard/app.py
@@ -18,7 +18,6 @@
     request,
     send_from_directory,
 )
-from karton.core import Producer
 from karton.core.backend import KartonMetrics
 from karton.core.base import KartonBase
 from karton.core.inspect import KartonAnalysis, KartonQueue, KartonState
@@ -51,16 +50,6 @@ class KartonDashboard(KartonBase):
 )
 
 
-def restart_tasks(tasks: List[Task]) -> None:
-    identity = "karton.dashboard-retry"
-    producer = Producer(identity=identity)
-
-    for task in tasks:
-        # spawn a new task and mark the original one as finished
-        producer.send_task(task.fork_task())
-        karton.backend.set_task_status(task=task, status=TaskState.FINISHED)
-
-
 def cancel_tasks(tasks: List[Task]) -> None:
     for task in tasks:
         karton.backend.set_task_status(task=task, status=TaskState.FINISHED)
@@ -280,7 +269,8 @@ def restart_crashed_queue_tasks(queue_name):
     if not queue:
         return jsonify({"error": "Queue doesn't exist"}), 404
 
-    restart_tasks(queue.crashed_tasks)
+    for task in queue.crashed_tasks:
+        karton.backend.restart_task(task)
     return redirect(request.referrer)
 
 
@@ -312,7 +302,7 @@ def restart_task(task_id):
     if not task:
         return jsonify({"error": "Task doesn't exist"}), 404
 
-    restart_tasks([task])
+    karton.backend.restart_task(task)
     return redirect(request.referrer)