-
Notifications
You must be signed in to change notification settings - Fork 41
Move pyproject.toml to root level dir #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes to docker/Dockerfile
or Makefile
. Those will break if left unmodified.
[tool.setuptools.packages.find] | ||
where = ["."] # list of folders that contain the packages (["."] by default) | ||
include = ["ssvc*"] # package names should match these glob patterns (["*"] by default) | ||
include = ["src*"] # package names should match these glob patterns (["*"] by default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want this to be src/ssvc/*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe it's where = ["./src"]
and leave include = ["ssvc*"]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 3 options successfully run uv sync
|
good catch. Didn't run docker... |
…convinced that this works.
Before we're done here, we should also:
|
Also note that the |
On this front, #986 makes the cut over to |
I think basically this line? I added the |
Resolves #974