TLS refactor #227
Open
TLS refactor #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiskaPavel
reviewed
Nov 7, 2024
process/tls_parser.cpp
Outdated
| } | ||
| bool TLSParser::parse_tls_header() const noexcept | ||
| { | ||
| const auto* tls_header = (const TLSHeader*) m_packet_data; |
There was a problem hiding this comment.
Nepouzivej to C-style pretypovani
process/tls_parser.cpp
Outdated
Comment on lines
105
to
144
| if ( sizeof(TLSHeader) + sizeof(TLSHandshake) > m_packet_length || | ||
| !(handshake->type == TLS_HANDSHAKE_CLIENT_HELLO || handshake->type == TLS_HANDSHAKE_SERVER_HELLO) || | ||
| handshake->version.major != 3 || | ||
| handshake->version.minor < 1 || | ||
| handshake->version.minor > 3) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Tady ty podminky mi prijdou celkem extrem.
Co to treba rozdelit do neceho takove:
if (hasHandshakeType(...) {
...
}
if (hasRequiredVersion()) {
...
}
process/tls_parser.cpp
Outdated
Comment on lines
118
to
119
| const auto session_id_section_offset | ||
| = sizeof(TLSHeader) + sizeof(TLSHandshake) + TLS_RANDOM_BYTES_LENGTH; |
There was a problem hiding this comment.
takoveto vypocty mohou byt constexpr
SiskaPavel
reviewed
Nov 8, 2024
process/tls_parser.hpp
Outdated
| std::vector<uint16_t> m_elliptic_curve_point_formats; | ||
| std::vector<std::pair<const char*, uint16_t>> m_alpns; | ||
| std::vector<uint16_t> m_supported_versions; | ||
| std::vector<std::pair<const char*, uint16_t>> m_serverNames; |
There was a problem hiding this comment.
Tady muzes pouzit std::vector<std::string_view> misto std::vector<std::pair<const char*, uint16_t>>
Zadamsa
force-pushed
the
tls-refactor
branch
5 times, most recently
from
123d004 to
dd4966c
Compare
SiskaPavel
reviewed
Nov 25, 2024
process/tls_parser.cpp
Outdated
| if (tls_header->type != TLS_HANDSHAKE){ | ||
| return false; | ||
| } | ||
| if (tls_header->version.major != 3 || tls_header->version.minor > 3){ |
There was a problem hiding this comment.
Sice se to formatovani zde automaticky nekontroluje, ale i presto zde plati coding style.
Jde hlavne o mezery za podminkami. V celem tomto MR je to hodne random.
SiskaPavel
reviewed
Nov 25, 2024
process/tls_parser.cpp
Outdated
Comment on lines
487
to
494
| // compute end of quic_transport_parameters | ||
| /*if (sizeof(uint16_t) > extension_length){ | ||
| return; | ||
| }*/ | ||
| /*const uint16_t quic_transport_parameters_length = ntohs(*reinterpret_cast<const uint16_t*>(extension_payload)); | ||
| if (sizeof(quic_transport_parameters_length) + quic_transport_parameters_length > extension_length) { | ||
| return; | ||
| }*/ |
There was a problem hiding this comment.
proc je tady tento kod?
Zadamsa
force-pushed
the
tls-refactor
branch
2 times, most recently
from
93692d4 to
388d807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.