Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy configuration for TESP #72

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

micoleaoo
Copy link

No description provided.

@micoleaoo micoleaoo requested a review from martenson January 26, 2025 09:42
@martenson
Copy link
Member

@@ -34,33 +34,19 @@ galaxy_job_config:
local_runner:
load: galaxy.jobs.runners.local:LocalJobRunner
workers: 4
pulsar_tpv_runner:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think, it's necessary to delete neither TPV runner nor TPV environment. You can just add new runner and environment for TESP and change only the default (line 50). This is global setting for all instances.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume guys are doing this just for testing at the moment, we need to devise a plan how to set up different job_confs anyways...likely put in separate files?

Copy link
Contributor

@martindemko martindemko Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we can separate job_config to default file in templates/galaxy/config/ and use the lookup-first_found:

"{{ lookup('first_found', ['templates/'+inventory_hostname+'/config/job_conf.yaml.j2', 'templates/
galaxy/config/job_conf.yaml.j2']) }}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternative is to define csnt_galaxy_job_config I guess

@martenson
Copy link
Member

try now with 5df8abb

@@ -206,7 +206,7 @@ galaxy_tmpclean_command: "{{ _galaxy_tmpclean_command[(ansible_os_family | lower
#galaxy_node_version: "XX.YY.Z"

# Where to clone Galaxy from. Backwards compatibility with galaxy_git_repo
galaxy_repo: "{{ galaxy_git_repo | default('https://github.com/galaxyproject/galaxy.git') }}"
# galaxy_repo: "{{ galaxy_git_repo | default('https://github.com/galaxyproject/galaxy.git') }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove any modifications to this file

galaxy.yml Outdated
@@ -105,7 +105,7 @@
- galaxyproject.tusd
- usegalaxy_eu.apptainer
- galaxyproject.galaxy
- usegalaxy_eu.tpv_auto_lint
# - usegalaxy_eu.tpv_auto_lint
Copy link
Member

@martenson martenson Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you likely need to revert this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants