adding the hide all but cell method #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [visibleCells addObject:[tableView cellForRowAtIndexPath:path]]; | ||
| } | ||
|
|
||
| for (SWBaseCell *checkCell in visibleCells) { |
There was a problem hiding this comment.
This should be changed from SWBaseCell to SWTableViewCell.
|
Works as expected for me and solved a bug with my implementation of a similar method. 👍 for the PR. |
| NSMutableSet *visibleCells = [[NSMutableSet alloc] init]; | ||
|
|
||
| for (NSIndexPath *path in paths) { | ||
| [visibleCells addObject:[tableView cellForRowAtIndexPath:path]]; |
There was a problem hiding this comment.
An improvement would be to change this line to this.
SWTableViewCell *cellForRow = (SWTableViewCell *)[tableView cellForRowAtIndexPath:path];
if (cellForRow)
{
[visibleCells addObject:cellForRow];
}
Without this change I've gotten the code to throw an exception here when hideUtilityButtons:exceptForCell:animated: is called in swipeableTableViewCellDidEndScrolling: and quickly showing the utility buttons and scrolling fast off the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case for the v2.0 Its On Me app where ... when you slide open one cell , it was required that any other open cell closed. I solved this use case by making a multi-purposed method that you could call from anywhere that resets any cell that isn't the cell you pass in. Pretty self explanatory. Thanks for the cool pod dude !
FYI, i overwrote in a base cell class in my version , I was un-able to overwrite as i am commiting below due to pod overwriting being a pain. So please run this before for any typos etc ... My base class version works perfectly .