Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and clarify dependencies #737

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Update and clarify dependencies #737

merged 2 commits into from
Jan 4, 2025

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Jan 3, 2025 •
edited
Loading

  • Add version of dependencies in the README.md and in the cmake files
  • update submodule googletest to v1.15.2
  • update submodule benchmark to v1.9.1

@tpadioleau tpadioleau self-assigned this Jan 3, 2025
@tpadioleau tpadioleau force-pushed the clarify-dependencies branch 2 times, most recently from ce845fb to 86fe339 Compare January 3, 2025 11:19
@tpadioleau tpadioleau force-pushed the clarify-dependencies branch from 86fe339 to f1d1455 Compare January 3, 2025 11:20
@tpadioleau tpadioleau requested a review from yasahi-hpc January 3, 2025 11:24
yasahi-hpc
yasahi-hpc previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could you add brief explanations for each optional component?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tpadioleau
Copy link
Member Author

LGTM. Could you add brief explanations for each optional component?

Sure good idea

@tpadioleau tpadioleau merged commit 5c6fd2d into main Jan 4, 2025
5 of 11 checks passed
@tpadioleau tpadioleau deleted the clarify-dependencies branch January 4, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc left review comments

Assignees

@tpadioleau tpadioleau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpadioleau @yasahi-hpc