Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move intelligence to Impl::create_mirror* #7

Open
wants to merge 20 commits into
base: refactor/create-mirror/constexpr
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
91d2707
Move intelligence from the create_mirror overloads to the Impl::creat…
thierryantoun Mar 21, 2024
d1bdc2e
Adding comments on create_mirror overloads
thierryantoun Mar 21, 2024
4adb813
Move intelligence from create_mirror_view overloads to Impl::create_m…
thierryantoun Mar 21, 2024
b3c30bc
Fix incorrect return for create_mirror_view
thierryantoun Mar 21, 2024
cf88dc8
Restrict MirrorViewType and MirrorType to only use a memory space
pzehner Mar 21, 2024
bb82074
Merge branch 'refactor/create-mirror/constexpr' into refactor/create-…
pzehner Mar 21, 2024
5e4f506
Check view is not specialized
pzehner Mar 22, 2024
4a9d02d
Put more explicit comments for functions
pzehner Mar 29, 2024
8613fb5
Reduce number of changes for namespaces in returns
pzehner Mar 29, 2024
cf56eef
Reduce more differences
pzehner Mar 29, 2024
353091f
Revert Space in Mirror*Type and make TestViewAPI.hpp::TestViewMirror:…
pzehner Mar 29, 2024
5d4cdc7
Fix the CTAD error
pzehner Apr 2, 2024
33a7f16
Merge branch 'refactor/create-mirror/constexpr' into refactor/create-…
pzehner Apr 4, 2024
b1e495f
Format with clang
thierryantoun Apr 4, 2024
2252860
Format Document
thierryantoun Apr 4, 2024
cd87ac0
Merge branch 'refactor/create-mirror/constexpr' into refactor/create-…
pzehner Apr 16, 2024
30b3d28
Merge branch 'refactor/create-mirror/constexpr' into refactor/create-…
pzehner Apr 17, 2024
2c9033a
Move intelligence for offset view create_mirror*
pzehner Apr 17, 2024
bbfd13f
Move intelligence for dynamic view create_mirror*
pzehner Apr 17, 2024
4e0f545
Move intelligence for dynamic rank view create_mirror*
pzehner Apr 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move intelligence for offset view create_mirror*
pzehner committed Apr 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 2c9033aaf66e3dfcada4121a1a881bda50060e15
6 changes: 4 additions & 2 deletions containers/src/Kokkos_OffsetView.hpp
Original file line number Diff line number Diff line change
@@ -1910,7 +1910,8 @@ inline auto create_mirror(
src, Kokkos::view_alloc(typename Space::memory_space{}));
}

template <class Space, class T, class... P>
template <class Space, class T, class... P,
typename Enable = std::enable_if_t<Kokkos::is_space<Space>::value>>
typename Kokkos::Impl::MirrorOffsetType<Space, T, P...>::view_type
create_mirror(Kokkos::Impl::WithoutInitializing_t wi, const Space&,
const Kokkos::Experimental::OffsetView<T, P...>& src) {
@@ -1983,7 +1984,8 @@ inline auto create_mirror_view(
src, Kokkos::view_alloc(typename Space::memory_space{}));
}

template <class Space, class T, class... P>
template <class Space, class T, class... P,
typename Enable = std::enable_if_t<Kokkos::is_space<Space>::value>>
inline auto create_mirror_view(
Kokkos::Impl::WithoutInitializing_t wi, const Space&,
const Kokkos::Experimental::OffsetView<T, P...>& src) {