Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevate PlayId to long because Play Ids are > Int32.MaxValue #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,4 @@ $RECYCLE.BIN/

# Visual Studio 2014 CTP
**/*.sln.ide
**/.vs/
2 changes: 1 addition & 1 deletion docs/PlayStat.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Name | Type | Description | Notes
**TeamScore** | **int?** | | [optional]
**OpponentScore** | **int?** | | [optional]
**DriveId** | **int?** | | [optional]
**PlayId** | **int?** | | [optional]
**PlayId** | **long?** | | [optional]
**Period** | **int?** | | [optional]
**Clock** | **Object** | | [optional]
**YardsToGoal** | **int?** | | [optional]
Expand Down
2 changes: 1 addition & 1 deletion docs/PlayWP.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**GamesId** | **int?** | | [optional]
**PlayId** | **int?** | | [optional]
**PlayId** | **long?** | | [optional]
**PlayText** | **string** | | [optional]
**HomeId** | **int?** | | [optional]
**Home** | **string** | | [optional]
Expand Down
9 changes: 5 additions & 4 deletions src/CFBSharp/CFBSharp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="FubarCoder.RestSharp.Portable.Core" Version="4.0.7" />
<PackageReference Include="FubarCoder.RestSharp.Portable.HttpClient" Version="4.0.7" />
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
<PackageReference Include="JsonSubTypes" Version="1.2.0" />
<PackageReference Include="FubarCoder.RestSharp.Portable.Core" Version="4.0.8" />
<PackageReference Include="FubarCoder.RestSharp.Portable.HttpClient" Version="4.0.8" />
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="JsonSubTypes" Version="1.9.0" />
</ItemGroup>


Expand Down
4 changes: 2 additions & 2 deletions src/CFBSharp/Model/Drive.cs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public partial class Drive : IEquatable<Drive>
/// <param name="startDefenseScore">startDefenseScore.</param>
/// <param name="endOffenseScore">endOffenseScore.</param>
/// <param name="endDefenseScore">endDefenseScore.</param>
public Drive(string offense = default(string), string offenseConference = default(string), string defense = default(string), string defenseConference = default(string), int? gameId = default(int?), int? id = default(int?), int? driveNumber = default(int?), bool? scoring = default(bool?), int? startPeriod = default(int?), int? startYardline = default(int?), int? startYardsToGoal = default(int?), Object startTime = default(Object), int? endPeriod = default(int?), int? endYardline = default(int?), int? endYardsToGoal = default(int?), Object endTime = default(Object), int? plays = default(int?), int? yards = default(int?), string driveResult = default(string), bool? isHomeOffense = default(bool?), int? startOffenseScore = default(int?), int? startDefenseScore = default(int?), int? endOffenseScore = default(int?), int? endDefenseScore = default(int?))
public Drive(string offense = default(string), string offenseConference = default(string), string defense = default(string), string defenseConference = default(string), int? gameId = default(int?), long? id = default(int?), int? driveNumber = default(int?), bool? scoring = default(bool?), int? startPeriod = default(int?), int? startYardline = default(int?), int? startYardsToGoal = default(int?), Object startTime = default(Object), int? endPeriod = default(int?), int? endYardline = default(int?), int? endYardsToGoal = default(int?), Object endTime = default(Object), int? plays = default(int?), int? yards = default(int?), string driveResult = default(string), bool? isHomeOffense = default(bool?), int? startOffenseScore = default(int?), int? startDefenseScore = default(int?), int? endOffenseScore = default(int?), int? endDefenseScore = default(int?))
{
this.Offense = offense;
this.OffenseConference = offenseConference;
Expand Down Expand Up @@ -117,7 +117,7 @@ public Drive(string offense = default(string), string offenseConference = defaul
/// Gets or Sets Id
/// </summary>
[DataMember(Name="id", EmitDefaultValue=false)]
public int? Id { get; set; }
public long? Id { get; set; }

/// <summary>
/// Gets or Sets DriveNumber
Expand Down
6 changes: 3 additions & 3 deletions src/CFBSharp/Model/Play.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public partial class Play : IEquatable<Play>
/// <param name="playText">playText.</param>
/// <param name="ppa">ppa.</param>
/// <param name="wallclock">wallclock.</param>
public Play(int? id = default(int?), int? driveId = default(int?), int? gameId = default(int?), int? driveNumber = default(int?), int? playNumber = default(int?), string offense = default(string), string offenseConference = default(string), int? offenseScore = default(int?), string defense = default(string), string home = default(string), string away = default(string), string defenseConference = default(string), int? defenseScore = default(int?), int? period = default(int?), Object clock = default(Object), int? offenseTimeouts = default(int?), int? defenseTimeouts = default(int?), int? yardLine = default(int?), int? yardsToGoal = default(int?), int? down = default(int?), int? distance = default(int?), int? yardsGained = default(int?), bool? scoring = default(bool?), string playType = default(string), string playText = default(string), decimal? ppa = default(decimal?), string wallclock = default(string))
public Play(long? id = default(long?), long? driveId = default(int?), int? gameId = default(int?), int? driveNumber = default(int?), int? playNumber = default(int?), string offense = default(string), string offenseConference = default(string), int? offenseScore = default(int?), string defense = default(string), string home = default(string), string away = default(string), string defenseConference = default(string), int? defenseScore = default(int?), int? period = default(int?), Object clock = default(Object), int? offenseTimeouts = default(int?), int? defenseTimeouts = default(int?), int? yardLine = default(int?), int? yardsToGoal = default(int?), int? down = default(int?), int? distance = default(int?), int? yardsGained = default(int?), bool? scoring = default(bool?), string playType = default(string), string playText = default(string), decimal? ppa = default(decimal?), string wallclock = default(string))
{
this.Id = id;
this.DriveId = driveId;
Expand Down Expand Up @@ -93,13 +93,13 @@ public Play(int? id = default(int?), int? driveId = default(int?), int? gameId =
/// Gets or Sets Id
/// </summary>
[DataMember(Name="id", EmitDefaultValue=false)]
public int? Id { get; set; }
public long? Id { get; set; }

/// <summary>
/// Gets or Sets DriveId
/// </summary>
[DataMember(Name="drive_id", EmitDefaultValue=false)]
public int? DriveId { get; set; }
public long? DriveId { get; set; }

/// <summary>
/// Gets or Sets GameId
Expand Down
6 changes: 3 additions & 3 deletions src/CFBSharp/Model/PlayStat.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public partial class PlayStat : IEquatable<PlayStat>
/// <param name="athleteName">athleteName.</param>
/// <param name="statType">statType.</param>
/// <param name="stat">stat.</param>
public PlayStat(int? gameId = default(int?), int? season = default(int?), int? week = default(int?), string team = default(string), string conference = default(string), string opponent = default(string), int? teamScore = default(int?), int? opponentScore = default(int?), int? driveId = default(int?), int? playId = default(int?), int? period = default(int?), Object clock = default(Object), int? yardsToGoal = default(int?), int? down = default(int?), int? distance = default(int?), int? athleteId = default(int?), string athleteName = default(string), string statType = default(string), int? stat = default(int?))
public PlayStat(int? gameId = default(int?), int? season = default(int?), int? week = default(int?), string team = default(string), string conference = default(string), string opponent = default(string), int? teamScore = default(int?), int? opponentScore = default(int?), long? driveId = default(int?), long? playId = default(long?), int? period = default(int?), Object clock = default(Object), int? yardsToGoal = default(int?), int? down = default(int?), int? distance = default(int?), int? athleteId = default(int?), string athleteName = default(string), string statType = default(string), int? stat = default(int?))
{
this.GameId = gameId;
this.Season = season;
Expand Down Expand Up @@ -125,13 +125,13 @@ public PlayStat(int? gameId = default(int?), int? season = default(int?), int? w
/// Gets or Sets DriveId
/// </summary>
[DataMember(Name="driveId", EmitDefaultValue=false)]
public int? DriveId { get; set; }
public long? DriveId { get; set; }

/// <summary>
/// Gets or Sets PlayId
/// </summary>
[DataMember(Name="playId", EmitDefaultValue=false)]
public int? PlayId { get; set; }
public long? PlayId { get; set; }

/// <summary>
/// Gets or Sets Period
Expand Down
4 changes: 2 additions & 2 deletions src/CFBSharp/Model/PlayWP.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public partial class PlayWP : IEquatable<PlayWP>
/// <param name="distance">distance.</param>
/// <param name="homeWinProb">homeWinProb.</param>
/// <param name="playNumber">playNumber.</param>
public PlayWP(int? gamesId = default(int?), int? playId = default(int?), string playText = default(string), int? homeId = default(int?), string home = default(string), int? awayId = default(int?), string away = default(string), decimal? spread = default(decimal?), bool? homeBall = default(bool?), int? homeScore = default(int?), int? awayScore = default(int?), int? timeRemaining = default(int?), int? yardLine = default(int?), int? down = default(int?), int? distance = default(int?), decimal? homeWinProb = default(decimal?), int? playNumber = default(int?))
public PlayWP(int? gamesId = default(int?), long? playId = default(int?), string playText = default(string), int? homeId = default(int?), string home = default(string), int? awayId = default(int?), string away = default(string), decimal? spread = default(decimal?), bool? homeBall = default(bool?), int? homeScore = default(int?), int? awayScore = default(int?), int? timeRemaining = default(int?), int? yardLine = default(int?), int? down = default(int?), int? distance = default(int?), decimal? homeWinProb = default(decimal?), int? playNumber = default(int?))
{
this.GamesId = gamesId;
this.PlayId = playId;
Expand Down Expand Up @@ -79,7 +79,7 @@ public PlayWP(int? gamesId = default(int?), int? playId = default(int?), string
/// Gets or Sets PlayId
/// </summary>
[DataMember(Name="playId", EmitDefaultValue=false)]
public int? PlayId { get; set; }
public long? PlayId { get; set; }

/// <summary>
/// Gets or Sets PlayText
Expand Down