Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagating new tests to develop #486

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Propagating new tests to develop #486

merged 8 commits into from
Jan 10, 2024

Conversation

llaniewski
Copy link
Member

No description provided.

@llaniewski llaniewski added the propagation Propagation of hotfix to downstream branches label Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 1884 lines in your changes are missing coverage. Please review.

Comparison is base (f7a0f5f) 43.23% compared to head (91f5769) 36.69%.
Report is 192 commits behind head on develop.

❗ Current head 91f5769 differs from pull request most recent head 36c4007. Consider uploading reports for the commit 36c4007 to get more accurate results

Files Patch % Lines
src/ArbLattice.cpp 0.00% 496 Missing ⚠️
src/CartLattice.cpp.Rt 38.16% 209 Missing ⚠️
src/LatticeBase.cpp.Rt 38.05% 166 Missing ⚠️
src/toArb.cpp 0.00% 128 Missing ⚠️
src/main.cpp 61.13% 89 Missing ⚠️
src/vtkLattice.cpp 29.89% 68 Missing ⚠️
src/vtuOutput.cpp 0.00% 61 Missing ⚠️
src/Geometry.cpp 42.10% 55 Missing ⚠️
src/ArbLatticeLauncher.hpp.Rt 0.00% 53 Missing ⚠️
src/Handlers/acUSAdjoint.cpp 6.12% 46 Missing ⚠️
... and 60 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #486      +/-   ##
===========================================
- Coverage    43.23%   36.69%   -6.54%     
===========================================
  Files          166      183      +17     
  Lines         7536     8380     +844     
===========================================
- Hits          3258     3075     -183     
- Misses        4278     5305    +1027     
Flag Coverage Δ
d2q9 ?
d3q27_PSM_NEBB 32.16% <33.94%> (-4.37%) ⬇️
d3q27_pf_velocity 27.34% <34.04%> (-3.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llaniewski llaniewski merged commit 93bf342 into develop Jan 10, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
propagation Propagation of hotfix to downstream branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants