Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSR] Same parameters but the result not the same on the Meeting Room dataset #8594

Open
happyfrank opened this issue Nov 8, 2024 · 1 comment · May be fixed by #8613
Open

[KSR] Same parameters but the result not the same on the Meeting Room dataset #8594

happyfrank opened this issue Nov 8, 2024 · 1 comment · May be fixed by #8613
Assignees

Comments

@happyfrank
Copy link

happyfrank commented Nov 8, 2024

Hello, recently while using the ksr_parameters.cpp example to test the meeting room dataset, I've set the parameters as specified in the CGAL documentation, but the results are not as the same as CGAL documentation.

Operating system: ubuntu 20.04 lts
Compiler: gcc 9.4.0
CGAL version: 6.0.1
Boost version: 1.71.0

/home/ubuntu/main/cgal-6.0.1/cmake-build-release/examples/Kinetic_surface_reconstruction/ksr_parameters

--- PARSING INPUT: 
* used kernel: CGAL::Epick
* parameters are saved in: parameters.ksr

--- INPUT PARAMETERS: 

--- INPUT STATS: 
* number of points: 3074625
verbose 0
maximum_distance 0.02999999999999999889
maximum_angle 19
min_region_size 100
k 3
graphcut_lambda 0.5
d: 0.014152370696312177242
dev: 17.870996526807875426
num: 15373
1634 detected planar shapes
ksp v: 177 f: 373 vol: 68856
Shape detection:        48.621866941452026367 seconds!
Kinetic partition:      187.26856708526611328 seconds!
 initialization:        23.293858051300048828 seconds!
 partition:             163.97470903396606445 seconds!
Kinetic reconstruction: 2.0781481266021728516 seconds!
Total time:             237.99756312370300293 seconds!


Process finished with exit code 0

parameters
output result

@soesau
Copy link
Member

soesau commented Nov 14, 2024

I confirm that that the numbers are not up to date for the parameters. I will look in to it and update the table in the documentation.
There is also a mix up in the table, from Meeting_room and below the regularization angle and offset are in the wrong column.
It is also possible that you may have forgotten to add -regparallel -regcoplanar -regoff 0.03 -regangle 10 to your command line.

If you set the the "Back-Face" to "Double" in Mesh-lab, the polygonal faces will be rendered correctly.

@soesau soesau linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants