Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Frechet Distance #8284

Open
wants to merge 269 commits into
base: master
Choose a base branch
from
Open

New package: Frechet Distance #8284

wants to merge 269 commits into from

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Jun 12, 2024 •
edited by afabri
Loading

Summary of Changes

Add a new package computing the approximate Fréchet distance between two polylines in dD under Euclidean metric, or decides if the distance is smaller than a given value.

Release Management

  • Affected package(s): Frechet_distance
  • Feature/Small Feature (if any): link
  • Link to compiled documentation: link
  • License and copyright ownership: MPI, GeometryFactory, cnrs(?)

TODO:

anusser and others added 30 commits February 22, 2024 14:14
@anusser
Another wip commit for the near neighbors search.
ff10eb3
@anusser
Query DS is now working including tests. Clean-up etc. still necessary.
6e87378
@anusser
Clean-up of Fréchet NNs data structure.
5fdc4cc 
Still not done, but at least a bit nicer.
@anusser
Use "= default" syntax for back_insert_it.
60fcb5e
@anusser
Further clean-up of Fréchet DS and add batch reporting for kd-tree.
4ab63f0
@anusser
Add PolylineTraits_2 class.
be3e40a 
This is just a starter to enable using the same types all over the
package.
@anusser
Make intersection into predicate. This commit introduces a segfault!
55ddcef 
Has to be debugged now...
@anusser
Fix segfault introduced in last commit.
0277586
@anusser
add TODO
11e00cd
@anusser
Add CGAL-like squared distance comparison to predicates.
211e9e3
@anusser
Continue CGALization
78481f3
@anusser
Copy predicates to _old files.
1d9c677
@anusser
Add some comments and notes.
274841b
@anusser
Add first draft of Polyline_d class.
821f384
@anusser
Some comments after call with Marvin.
4adf5ba
Re-insert outer interval as we need it for robustness of our old code.
f8524ad
Fix tests and compilation errors.
81930a9
Small changes after meeting with Andreas.
9a9dde4
Pass after another rough review.
ac4f8d6
Take out near neighbor code in tests to reduce errors.
c56a57d
Switched partly to CGAL::Point_2.
7bd03fe 
Compiles and the tests succeeded.
Switch out distance computation with CGAL::squared_distance.
d1eb0fe
Clean up.
fc6e599
A version that passes the tests with CPoint having CORE::Expr type.
28d44e2 
This is unfortunately super slow.
Change directory in test such that it can be run from build.
51fabfb
Version that works with Sqrt_ext and Rational but very slow
b353bd5
Add brief license information to the SIGSPATIAL data.
f149567
Fix authors and add license headers.
2484d3a
@afabri
Various fixes so that it compiles with VC++
ad109d2
@afabri
WIP failing on some curves, that avoids Rational
e95f95a
sloriot and others added 30 commits October 30, 2024 17:44
@sloriot
WIP
6c9d514
@sloriot
still WIP
fb689fa
@sloriot
factorize curve
28db6f3
@sloriot
start following the concept
95d810f
@sloriot
compilation errors
48b204b
@sloriot
make it work with SC<ER>
e76b975
@sloriot
always use Interval for prefix_length as it is used in filters
6c3b548
@sloriot
remove sqrt
7f8d80a
@sloriot
doc fixes
f216e31
@sloriot
using functor to iterator over coordinates
7f0a121
@sloriot
remove useless abs
107ed0f
@sloriot
do not use interval for SC<double>
aa009bc
@sloriot
use traits object functions
9945425
@sloriot
avoid exception
f0ef1af
@sloriot
fix EPICK implementation
a13d326
@sloriot
missing return type
e3458be
@sloriot
test all kernels
a173749
@sloriot
conditional testing
a1cd361
@sloriot
no need to construct points
e1f5a1b
@sloriot
add filtering for EPECK too
c2d7402
@sloriot
add filtering also for Kernel with no filtering
b3f420e
@sloriot
enable filtering with exact nt with custom traits
5bb5aa9
@sloriot
enable filtering for Epick_d
759fc87
@sloriot
do not change the rounding mode since protector is already created be…
0b6b64a 
…fore
@sloriot
Merge remote-tracking branch 'cgal/master'
efc600e
@sloriot
Merge pull request CGAL#8611 from sloriot/NT-sqrt_rounding
d61a3e3 
Remove extra rounding mode changes for sqrt for interval
@sloriot
fix copy/paste issues
090154d
@sloriot
clean up
9a0dd64
@afabri
Fix include for header checks
6b66736
@afabri
Fix dependencies
b4b3839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglisse mglisse mglisse left review comments

@albert-github albert-github albert-github left review comments

@afabri afabri afabri left review comments

Assignees
No one assigned
Labels
CHANGES.md not updated Feature Not yet approved The feature or pull-request has not yet been approved.
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.

Epick_d and Has_filtered_predicates_tag
7 participants
@lrineau @afabri @mglisse @albert-github @MaelRL @anusser @sloriot