Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean fakes option when purging orphans. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ezragoss
Copy link

Just as an artist-friendly precaution I included an option to clean fake users flags on export so the dependency graph doesn't pull in unused items that depend on other items that depend on fake users.

I haven't looked a ton at the node export code so this is just for the non-node exports but if this is relevant to nodes as well its a simple add.

I've tested this with collection and object exports and it seems to work fine.

@Fweeb
Copy link
Collaborator

Fweeb commented Mar 2, 2023

Conceptually, I like this idea. However, sculpting brushes are all datablocks with fake users. The code in your pull request clears the fake users these brushes, making them unavailable in the saved .blend file. That's not ideal... especially if the exported object is sculpted and the user intends to refine it further after export.

Maybe it makes sense to filter and exclude "native" datatypes like Brushes.

@ezragoss
Copy link
Author

I was thinking something similar. The more I looked into this after opening this PR the more I think we can get sophisticated with the purge. This methodology of purging scenes prior to asset export has been something I've been implementing as a sidecar to this plugin for clients since I opened this PR and its saved a ton of time and money - so at least practically I can say it's desired in production! But agreed that we don't want to brute force the purge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants