WIP: Warehouse identifier for orders and users #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdwieber
approved these changes
Dec 30, 2022
|
@cdwieber it's missing a few features at the moment lol. |
samdark
reviewed
Jan 7, 2023
samdark
reviewed
Jan 7, 2023
| */ | ||
| public static function getList($keyField = 'id', $valueField = 'name') | ||
| { | ||
| $data = self::find()->orderBy([$valueField => SORT_ASC])->all(); |
There was a problem hiding this comment.
How many warehouses are going to be in the database?
There was a problem hiding this comment.
Initially it'll only be about 10 or so.
There was a problem hiding this comment.
When it will grow big, this solution won't work.
| $this->createTable('{{%user_warehouse}}', [ | ||
| 'id' => $this->primaryKey(), | ||
| 'warehouse_id' => $this->integer()->notNull(), | ||
| 'user_id' => $this->integer()->notNull(), |
There was a problem hiding this comment.
Should we define foreign keys for these?
There was a problem hiding this comment.
Yes. I'll get that added.
frontend/views/order/_form.php
Outdated
| @@ -60,6 +60,15 @@ | |||
| <?= $form->field($model->order, 'customer_id') | |||
| ->dropdownList($customers, ['prompt' => ' Please select']) ?> | |||
|
|
|||
|
|
|||
| <?php | |||
| // i think i only want this for admins right now... needs more thought | |||
Co-authored-by: Alexander Makarov <[email protected]>
# Conflicts: # frontend/controllers/OrderController.php # frontend/models/User.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #98
Users will either be associated with
customersorwarehouses. This way a warehouse user can see all customers that have orders with 'Warehouse 1' and customers can have multiple fulfillment centers. This also allows us to send requests upstream to the warehouses when modifications or cancellations are required.** Accidentally created a PR as open instead of draft.