Updated ID1A3.json and ID3A.json schemas #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description for "Facility" key
Deleted duplicate CHEXS_NSF value in BeamlineFundingPartner
Added EnergyScanDocument key
Added keys for slit settings
Added InsertionDevice key
Deleted duplicate CCU value in InsertionDevice key
Added "None" to the list of values for Focusing key
Added AttenMaterial, AttenThickness, and EnergyFoil keys
Deleted duplicate CCU value in InsertionDevice
Moved Calibration key to the top of Sample section, and then added CalibrationDocument key (string, optional, multiple false)
Added new keys in Sample section, and slightly modified the order in which the keys appear in the section.
Added SampleState key in Sample section
Deleted duplicate entry in Sample section
Added SampleState key in Sample section
Fixed minor errors in Sample section
Fixed errors in Sample section
Changed order of some keys in Beam section
General cleanup throughout
General cleanup throughout
Added keys for detector slit settings for white beam mode
More cleanup
Moved DataLocations section after User section
vkuznet
requested changes
Sep 14, 2023
web/schemas/ID1A3.json
Outdated
| "multiple": true, | ||
| "section": "Beam", | ||
| "description": "Thickness [mm] of attenuator(s) - enter one value for each attenutor material", | ||
| "placeholder": "0.25, 3.0" |
There was a problem hiding this comment.
This is wrong. You should either define single number for placeholder or if you expect a list of numbers you should change the type. Please clarify.
There was a problem hiding this comment.
Fixed. A similar fix was applied to ID3A.json also. Made a few more minor edits to both ID1A3.json and ID3A.json.
Edited placeholder for AttenThickness key to have a single value; and general cleanup
Edited placeholder for AttenThickness key; and general cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vkuznet: ID1A3.json and ID3A.json schemas updated.