Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs + added option for journals #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed bugs + added option for journals #1

wants to merge 1 commit into from

Conversation

danielemichilli
Copy link

The argparse wasn't running for me so I edited the malfunctioning part. I also added an option to select the journal instead of hardcoding it

dstndstn
dstndstn reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@dstndstn dstndstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

For the "%(default)", it looks like I forgot to format it correctly as "%(default)s"; that other version worked for some previous version of python -- but it's fine to omit it as you did here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstndstn dstndstn dstndstn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielemichilli @dstndstn